[release/9.0] Prevent owner entity from becoming optional #35222
+78
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maumar
reviewed
Nov 27, 2024
| @@ -1,6 +1,7 @@ | |||
| // Licensed to the .NET Foundation under one or more agreements. | |||
| // The .NET Foundation licenses this file to you under the MIT license. | |||
|
|
|||
| using System.Reflection.Emit; | |||
maumar
approved these changes
Nov 27, 2024
AndriySvyryd
force-pushed
the
Issue35110
branch
from
a7ad95c to
7baf361
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35110
Description
Due to a bug when a relationship is configured as owned after being discovered by convention it is not configured as required explicitly, so if it's configured over nullable properties another convention can mark the relationship as optional. However, this cannot be represented in the model snapshot used in migration, so the snapshot always appears as out-of-date.
Customer impact
This scenario is not very common, but for apps that are affected an exception is thrown when the migrations are applied. The workaround is to ignore the warning using options.
How found
Customer reported on 9.
Regression
Yes, from 8.
Testing
Tests added.
Risk
Low and quirked.